fix: update job status for local fileglancer job executor#361
Open
allison-truhlar wants to merge 2 commits intomainfrom
Open
fix: update job status for local fileglancer job executor#361allison-truhlar wants to merge 2 commits intomainfrom
allison-truhlar wants to merge 2 commits intomainfrom
Conversation
The LocalExecutor tracks running processes in-memory, but the worker
subprocess architecture creates a fresh executor for each submit/poll
invocation. The submit worker's process references are lost when it
exits, so the poll worker's executor.poll() never detects status changes.
Fix by bypassing the worker subprocess for local executor polling:
- Write the subprocess PID to {work_dir}/job.pid during submit
- Add a bash EXIT trap to capture exit code in {work_dir}/exit_code
- Poll by checking PID liveness via os.kill(pid, 0) instead of
spawning a worker that creates a new (empty) executor
- any string would cause kwargs.get("status") to be true, and the second condition to check for "RUNNING" would never be checked.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clickup id: 86agx94bg
The LocalExecutor tracks running processes in-memory, but the worker subprocess architecture creates a fresh executor for each submit/poll invocation. The submit worker's process references are lost when it exits, so the poll worker's executor.poll() never detects status changes.
Fix by bypassing the worker subprocess for local executor polling:
@krokicki