Skip to content

Move remaining path functions from Defaults module in cardano-testnet to Cardano.Node.Testnet.Paths in cardano-node#6586

Merged
palas merged 6 commits into
masterfrom
move-more-defaults-to-node
Jun 3, 2026
Merged

Move remaining path functions from Defaults module in cardano-testnet to Cardano.Node.Testnet.Paths in cardano-node#6586
palas merged 6 commits into
masterfrom
move-more-defaults-to-node

Conversation

@palas
Copy link
Copy Markdown
Contributor

@palas palas commented Jun 1, 2026

Description

Closes #6532.

Move all path and filename definition functions from Testnet.Defaults (in cardano-testnet) to
Cardano.Node.Testnet.Paths (in cardano-node), so that consumers of generated testnet
configurations can reference canonical paths without depending on cardano-testnet.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
    • integration tests
      See Running tests for more details
  • Any changes are noted in the CHANGELOG.md for affected package
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-9.6 and ghc-9.12
  • Self-reviewed the diff

@palas palas requested a review from a team as a code owner June 1, 2026 23:39
@palas palas linked an issue Jun 1, 2026 that may be closed by this pull request
@palas palas self-assigned this Jun 1, 2026
@palas palas changed the title Move remaining path functions from Defaults to Cardano.Node.Testnet.Paths Move remaining path functions from Defaults module in cardano-testnet to Cardano.Node.Testnet.Paths in cardano-node Jun 1, 2026
@palas palas force-pushed the move-more-defaults-to-node branch from 4397ada to ceb1f79 Compare June 2, 2026 00:25
@palas palas force-pushed the move-more-defaults-to-node branch from ceb1f79 to 3ed9ac6 Compare June 2, 2026 00:54
Comment thread cardano-node/src/Cardano/Node/Testnet/Paths.hs
Comment thread cardano-testnet/src/Testnet/Defaults.hs Outdated
@palas palas enabled auto-merge June 2, 2026 22:56
@palas palas added this pull request to the merge queue Jun 3, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to no response for status checks Jun 3, 2026
@palas palas added this pull request to the merge queue Jun 3, 2026
Merged via the queue into master with commit a53156c Jun 3, 2026
31 checks passed
@palas palas deleted the move-more-defaults-to-node branch June 3, 2026 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consider moving some defaults from Testnet.Defaults to cardano-node

2 participants