Minor updates#1387
Conversation
There was a problem hiding this comment.
Pull request overview
Updates project dependency pinning to newer Nix inputs and Cabal index-states, while adjusting build constraints/overrides for current compiler compatibility.
Changes:
- Bumped Nix flake inputs (CHaP and hackage.nix) in
flake.lock. - Updated
index-statepins and reduced theallow-newerset for GHC ≥ 9.14 incabal.project. - Added a new top-level Cabal constraint (
validation < 1.2) incabal.project.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| flake.lock | Updates locked revisions/hashes for Nix inputs (CHaP, hackage.nix). |
| cabal.project | Updates index-states and adjusts constraints/allow-newer overrides for builds. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| -- ouroboros-consensus currently needs this. Version 1.2 has an breaking API change. | ||
| constraints: | ||
| , validation < 1.2 |
There was a problem hiding this comment.
Is this still needed? o-c has revision with this constraint:
There was a problem hiding this comment.
But this tree is still using ouroboros-consensus-3.0.0.0 so that constraint is needed. Unless you would prefer I do a revision of ouroboros-consensus-3.0.0.0
There was a problem hiding this comment.
That's strange why. We have only ^>= 3.0 constraint so it should pull 3.0.1 with newer chap I think.
If that is not the case, we can merge your PR as it is.
There was a problem hiding this comment.
I made a revision to ouroboros-consensus-3.0.0.0 to force validation < 1.2 and I removed the constraint as well.
|
Removed from queue, could you double check that validation constraint, @erikd ? Otherwise LGTM. |
Context
Minior updates:
Checklist
.changes/