ENH: kernels for random.vonmisses; part 1#779
Merged
Conversation
Author
shssf
reviewed
Jul 12, 2021
| result1[i] = (resi < 0) ? -mod : mod; | ||
| } | ||
| cl::sycl::range<1> gws(size); | ||
| auto paral_kernel_acceptance = [&](cl::sycl::handler& cgh) { |
Contributor
There was a problem hiding this comment.
it looks like this lambda is mostly the same as in other part of code. I suspect, this will be used for many other part of code.
If it is not - please drop off this message.
So, perhaps it is better to make it as a macro or, that is better, as inline function in this C++ source. Just to avoid code duplication.
This is not quite important. It might be leaved as is, at least for now.
Author
There was a problem hiding this comment.
@shssf There is no code duplication here. Please read messages carefully)
Author
There was a problem hiding this comment.
@shssf Actually you are right. But it is valuable, when we reusing the same code more than 2 times. I vote leave it as is.
shssf
approved these changes
Jul 12, 2021
shssf
approved these changes
Jul 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Enable computations on devices [CPU/GPU].
Tests