Technical debt changes in indexing functions#2012
Draft
ndgrigorian wants to merge 2 commits intomasterfrom
Draft
Technical debt changes in indexing functions#2012ndgrigorian wants to merge 2 commits intomasterfrom
ndgrigorian wants to merge 2 commits intomasterfrom
Conversation
4802fbd to
7dfd4b9
Compare
|
View rendered docs @ https://intelpython.github.io/dpctl/pulls/2012/index.html |
|
Array API standard conformance tests for dpctl=0.19.0dev0=py310h93fe807_537 ran successfully. |
7dfd4b9 to
0d7baf0
Compare
|
Array API standard conformance tests for dpctl=0.19.0dev0=py310h93fe807_537 ran successfully. |
Collaborator
Aligns with most non-constructors
0d7baf0 to
d409117
Compare
|
Array API standard conformance tests for dpctl=0.20.0dev0=py310h93fe807_115 ran successfully. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR cleans up indexing functions
usm_ndarray_takeandusm_ndarray_puttopy_takeandpy_putto improve consistency with the rest of dpctl_populate_kernel_paramsinternal function to improve code readability [WIP]