Conversation
- Switch XML parsing to defusedxml in xml_file, generate_xml_report, and writers to address Bandit B314/B318/B405/B408 and Semgrep use-defused-xml warnings; mark stdlib imports kept for typing or construction with nosec/nosemgrep. - Add defusedxml runtime dependency in pyproject.toml. - Validate package names with a strict regex before importlib.import_module in PackageManager to address Semgrep non-literal-import. - Drop unused imports (queue, os, json, Union, TestRecord) and tag side-effect request_hook import with noqa: F401. - Rename Sphinx conf copyright to project_copyright to stop builtin shadow. - Configure Bandit (pyproject.toml) and Codacy (.codacy.yaml) to skip B101 in test files.
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
CI installs deps from requirements.txt / dev_requirements.txt against the published package, so the new pyproject.toml dependency does not reach the runner until release. Add defusedxml directly so test collection imports succeed.
Also align dev.toml setuptools floor with pyproject.toml.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
defusedxml(xml_file, generate_xml_report); annotate stdlib imports kept for typing/construction with# nosecand# nosemgrep.defusedxml>=0.7.1runtime dependency.PackageManager.load_package_if_availablewith a strict regex whitelist beforeimportlib.import_moduleto address Semgrep non-literal-import.queue,os,json,Union,TestRecord); preserverequest_hookside-effect import with# noqa: F401.copyrighttoproject_copyrightto stop shadowing the builtin.[tool.bandit]inpyproject.toml) and Codacy (.codacy.yaml) soB101is skipped intest/**(pytest-asserts are intentional).Clears all 140 issues currently reported by the Codacy API:
copyright)Test plan
pytest test/— 84 passedreformat_xml_file,XMLParser,dict_to_elements_treeafter the defusedxml swap