ENH: Update GitHub Actions configuration for ITK 5.4.0#98
Open
thewtex wants to merge 3 commits intoInsightSoftwareConsortium:masterfrom
Open
ENH: Update GitHub Actions configuration for ITK 5.4.0#98thewtex wants to merge 3 commits intoInsightSoftwareConsortium:masterfrom
thewtex wants to merge 3 commits intoInsightSoftwareConsortium:masterfrom
Conversation
jhlegarreta
reviewed
May 29, 2024
Member
jhlegarreta
left a comment
jhlegarreta
left a comment
There was a problem hiding this comment.
Thanks for doing this Matt.
Member
Author
|
I think we need to move to a different JSON library -- the existing one fails to build with MSVC and is not maintained. |
Contributor
This one is really famous: https://github.com/nlohmann/json, it seems great to use, but slow performance (not sure about our requirements). The fastest is simdjson: https://github.com/simdjson/simdjson/#performance-results |
Member
Author
|
:Ooo:, simdjson looks nice! I am also finding glaze: https://github.com/stephenberry/glaze Claims to be faster than simdjson, but requires C++20. Has a neat reflection API. |
Merged
To address: D:\a\ITKPerformanceBenchmarking\ITKPerformanceBenchmarking\src\jsonxx.cc(222): error C2143: syntax error: missing ':' before '...' D:\a\ITKPerformanceBenchmarking\ITKPerformanceBenchmarking\src\jsonxx.cc(222): error C2059: syntax error: '...'
hjmjohnson
force-pushed
the
ci-updates
branch
from
b9f6c33 to
0b5ad20
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Points to
main, which is currently up-to-date with ITK v5.4.0.