Adjust display init sequence to fix a rotation issue on the new ST7789P3 display controller#2440
Open
JF002 wants to merge 1 commit into
Open
Adjust display init sequence to fix a rotation issue on the new ST7789P3 display controller#2440JF002 wants to merge 1 commit into
JF002 wants to merge 1 commit into
Conversation
…9P3 display controller.
|
Build size and comparison to main:
|
|
In #2439 you mentioned a 120ms delay. I don’t see that in this change. Is it required? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Those changes were suggested by PineStore engineering team to ensure that the new ST7789P3 will be supported by InfiniTime.
They basically move the call to the SLEEPOUT command after all the registers have been set. This should fix the rotation issue they detected while testing the new display.
Fixes #2439