Skip to content

Revert "skip build flash attn target when disabled" #1068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wooway777 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Revert "skip build flash attn target when disabled" #1068

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion xmake.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -461,7 +461,7 @@ target("infinicore_cpp_api")
add_linkdirs(INFINI_ROOT.."/lib")
add_links("infiniop", "infinirt", "infiniccl")

if get_config("flash-attn") ~= "" and get_config("flash-attn") ~= nil then
if get_config("flash-attn") ~= "" then
add_installfiles("(builddir)/$(plat)/$(arch)/$(mode)/flash-attn*.so", {prefixdir = "lib"})
if has_config("nv-gpu") then
add_deps("flash-attn-nvidia")
Expand Down
1 change: 0 additions & 1 deletion xmake/nvidia.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,6 @@ target("flash-attn-nvidia")
before_build(function (target)
print("Flash Attention not available, skipping flash-attn-nvidia build")
end)
on_build(function (target) end)
end

on_install(function (target) end)
Expand Down