Make PCA projection reproducible given seed#46
Draft
NetZissou wants to merge 1 commit into
Draft
Conversation
sklearn auto-selects the randomized SVD solver for large inputs, calling PCA(n_components=2) without `random_state` produced a different projection on every run. Now fixed by passing the seed to the API call. cuML PCA is left unchanged: it has no random_state parameter (passing one raises TypeError and silently falls back to sklearn), and its full-SVD solver is already deterministic. Verified on a V100: cuML PCA stays on GPU path and is reproducible run-to-run.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sklearn auto-selects the randomized SVD solver for large inputs, calling PCA(n_components=2) without
random_stateproduced a different projection on every run. Now fixed by passing the seed to the API call.cuML PCA is left unchanged: it has no
random_stateparameter (passing one raises TypeError and silently falls back to sklearn), and its full-SVD solver is already deterministic. Verified on a V100: cuML PCA stays on GPU path and is reproducible run-to-run. Changing the solver to "jacobi" doesn't make sense for the interactive scale data with 768 dim.