docs(skills): Replace ng-deep with tokens in generate-from-image-design skill#17228
Open
georgianastasov wants to merge 2 commits intomasterfrom
Open
docs(skills): Replace ng-deep with tokens in generate-from-image-design skill#17228georgianastasov wants to merge 2 commits intomasterfrom
georgianastasov wants to merge 2 commits intomasterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the igniteui-angular-generate-from-image-design skill documentation to steer users away from ::ng-deep and toward applying component theme overrides via the tokens mixin, aligning the guidance with current Ignite UI theming recommendations.
Changes:
- Updated Step 5c in the skill to instruct applying component themes using
@include tokens(<theme-name>);instead of::ng-deep. - Reworked the
IgxGridComponentdark-theme “gotcha” to remove internal-class overrides and reference thecreate_component_theme+tokensapproach.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| skills/igniteui-angular-generate-from-image-design/references/gotchas.md | Replaces ::ng-deep/internal-class grid overrides with a tokens-based theming note/snippet. |
| skills/igniteui-angular-generate-from-image-design/SKILL.md | Updates Step 5c guidance to apply generated component themes via tokens rather than ::ng-deep. |
simeonoff
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Addresses feedback from @simeonoff on the igniteui-angular-generate-from-image-design skill.
Resolved:
SKILL.md Step 5c — Replaced "Apply the generated theme blocks inside ::ng-deep scoped to the component selector" with guidance to use @include tokens();, which works without ::ng-deep even with emulated ViewEncapsulation.
gotchas.md: Dark theme overrides for IgxGridComponent". Removed the ::ng-deep block targeting internal grid classes (.igx-grid__thead, .igx-grid__tr, etc.) and replaced it with the tokens mixin approach via create_component_theme.
Motivation / Context
These address the two related comments:
"Component theme mixins should NOT be used. When requesting a component theme from the MCP server the server returns a complete theme with @include tokens(); This should be sufficient even in Emulated view encapsulation scenarios." - #17181 (comment)
"Also the ::ng-deep should not be needed when using the tokens mixin. Not to mention that component-specific mixins have been deprecated for a long time now." - #17181 (comment)
Type of Change (check all that apply):
Component(s) / Area(s) Affected:
Skills
How Has This Been Tested?
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)