chore(*): Apply different throttle based on the amount of data in dis…#16879
Merged
rkaraivanov merged 9 commits intomasterfrom Feb 11, 2026
Merged
chore(*): Apply different throttle based on the amount of data in dis…#16879rkaraivanov merged 9 commits intomasterfrom
rkaraivanov merged 9 commits intomasterfrom
Conversation
Member
|
@MayaKirova , @rkaraivanov , this one looks good to me. Not only it doesn't regress the perceived performance of smaller grids, but also substantially improves it for very dense ones. Please, fix the tests and add a changelog for this improvement. |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates grid virtual scrolling to use a dynamic throttle that scales with the rendered cell count by introducing a configurable “multiplier” token and emitting chunk size changes from the IgxForOfDirective.
Changes:
- Replaces fixed
throttleTimeusage with a dynamicthrottleduration selector driven by a subject. - Adds
chunkSizeChangeoutput toIgxForOfDirective/ token and wires it into the grid to recalculate throttle. - Updates multiple grid-related specs to provide the new injection token.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
projects/igniteui-angular/grids/grid/src/grid-base.directive.ts |
Introduces adaptive scroll throttling driven by chunk size changes and a new injection token. |
projects/igniteui-angular/directives/src/directives/for-of/for_of.directive.ts |
Emits chunkSizeChange when chunk size changes to allow consumers (grids) to react. |
projects/igniteui-angular/grids/tree-grid/src/tree-grid-summaries.spec.ts |
Switches provider from old throttle token to new multiplier token. |
projects/igniteui-angular/grids/tree-grid/src/tree-grid-multi-cell-selection.spec.ts |
Switches provider from old throttle token to new multiplier token (and adjusts some values). |
projects/igniteui-angular/grids/tree-grid/src/tree-grid-keyBoardNav.spec.ts |
Switches provider from old throttle token to new multiplier token. |
projects/igniteui-angular/grids/hierarchical-grid/src/hierarchical-grid.virtualization.spec.ts |
Switches provider from old throttle token to new multiplier token. |
projects/igniteui-angular/grids/hierarchical-grid/src/hierarchical-grid.navigation.spec.ts |
Switches provider from old throttle token to new multiplier token. |
projects/igniteui-angular/grids/grid/src/grid.master-detail.spec.ts |
Switches provider from old throttle token to new multiplier token. |
projects/igniteui-angular/grids/grid/src/grid.component.spec.ts |
Switches provider from old throttle token to new multiplier token. |
projects/igniteui-angular/grids/grid/src/grid-mrl-keyboard-nav.spec.ts |
Switches provider from old throttle token to new multiplier token. |
projects/igniteui-angular/grids/grid/src/grid-keyBoardNav.spec.ts |
Switches provider from old throttle token to new multiplier token. |
projects/igniteui-angular/grids/grid/src/grid-cell-selection.spec.ts |
Switches provider from old throttle token to new multiplier token. |
projects/igniteui-angular/grids/grid/src/grid-base.directive.ts
Outdated
Show resolved
Hide resolved
projects/igniteui-angular/grids/grid/src/grid-base.directive.ts
Outdated
Show resolved
Hide resolved
rkaraivanov
approved these changes
Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…play.
Closes #
Additional information (check all that apply):
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)