Skip to content

Add strict type declarations to Events::isValidEvent()#69

Open
Jan-Schuppik wants to merge 1 commit intomainfrom
modernize-code-with-breaking-changes
Open

Add strict type declarations to Events::isValidEvent()#69
Jan-Schuppik wants to merge 1 commit intomainfrom
modernize-code-with-breaking-changes

Conversation

@Jan-Schuppik
Copy link
Copy Markdown
Contributor

@Jan-Schuppik Jan-Schuppik commented Mar 12, 2026

This breaking change requires adjustments to the following consumers:

ipl-html:

  • src/FormElement/FormElements.php

ipl-web:

  • src/Control/SearchBar.php

notifications-web:

  • library/Notifications/Web/Form/ContactForm.php

vspheredb:

  • library/Vspheredb/Web/Form/VCenterShipMetricsForm.php
  • library/Vspheredb/Web/Form/PerfdataConsumerForm.php

@cla-bot cla-bot Bot added the cla/signed label Mar 12, 2026
@Jan-Schuppik Jan-Schuppik changed the title Modernize code with breaking changes Breaking changes in modernize code Mar 13, 2026
@lippserd lippserd changed the title Breaking changes in modernize code Add strict types to Events::isValidEvent() Mar 23, 2026
@lippserd lippserd added this to the v1.0.0 milestone Mar 23, 2026
@lippserd lippserd removed this from the v1.0.0 milestone Apr 10, 2026
@lippserd lippserd force-pushed the modernize-code-with-breaking-changes branch 2 times, most recently from 91d0428 to 98d5fe4 Compare April 30, 2026 16:16
@lippserd lippserd changed the title Add strict types to Events::isValidEvent() Add strict type declarations to Events::isValidEvent() Apr 30, 2026
This breaking change requires adjustments to the following consumers:

ipl-html:
  - src/FormElement/FormElements.php

ipl-web:
  - src/Control/SearchBar.php

notifications-web:
  - library/Notifications/Web/Form/ContactForm.php

vspheredb:
  - library/Vspheredb/Web/Form/VCenterShipMetricsForm.php
  - library/Vspheredb/Web/Form/PerfdataConsumerForm.php
@lippserd lippserd force-pushed the modernize-code-with-breaking-changes branch from 98d5fe4 to 05335d9 Compare April 30, 2026 16:18
@lippserd lippserd added this to the v1.0.0 milestone Apr 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants