add: animation curves support#4164
Draft
Gavin-Niederman wants to merge 6 commits into
Draft
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces an AnimationCurve implementation, featuring keyframe-based interpolation (Linear, Constant, and Bezier) and integration into the node graph system via new nodes and registry updates. Review feedback suggests refining the evaluation logic to clamp out-of-bounds values to the nearest keyframe for better consistency and optimizing keyframe insertion using binary search to improve performance and data validation.
Keavon
force-pushed
the
add/animation-curves
branch
from
0105b40 to
3ddcda6
Compare
Member
|
Note: I rebased your branch. |
Member
|
Hey, just checking in on the latest with this, thanks! |
Author
I haven't been able to do any development in a bit but im going to start working on this again now! |
Gavin-Niederman
force-pushed
the
add/animation-curves
branch
from
7b3a110 to
d5b3c88
Compare
Gavin-Niederman
force-pushed
the
add/animation-curves
branch
from
d5b3c88 to
2ef8042
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A work-in-progress PR adding support for f-curves and a timeline
NodeInputvariant.TODO:
AnimationCurve(f-curves implementation based on Blender's system)NodeInputvariant.Note
the
replace_timeline_inputs_with_nodesfunction was mostly written with AI (Opus 4.8). I have thoroughly reviewed it and tested it.Demo
demo.mp4