Fix panic when hiding nodes with zero inputs#4134
Open
kimjune01 wants to merge 1 commit intoGraphiteEditor:masterfrom
Open
Fix panic when hiding nodes with zero inputs#4134kimjune01 wants to merge 1 commit intoGraphiteEditor:masterfrom
kimjune01 wants to merge 1 commit intoGraphiteEditor:masterfrom
Conversation
Nodes like PointerPositionNode have no value inputs (context-only). drain(1..) panics on an empty Vec. Guard with an is_empty check: push a synthetic None input for empty nodes, truncate to 1 otherwise. Adds regression tests for zero-input and multi-input cases. Fixes GraphiteEditor#3629
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request fixes a panic in NodeNetwork that occurred when hiding a node with zero inputs. The code now safely handles empty input vectors by adding a default input or truncating to the first element, ensuring passthrough nodes maintain the required single input. Two unit tests were added to verify the fix and prevent regressions. I have no feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3629.
Nodes like
PointerPositionNodehave no value inputs — they only receive context.drain(1..)panics on an emptyVec. Guard with anis_emptycheck: push a syntheticNoneinput for empty-input nodes,truncate(1)otherwise.Adds regression tests for zero-input and multi-input hidden nodes.