-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Finalize and unify the design of the 'Morph' and 'Blend' nodes #3974
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Keavon
wants to merge
24
commits into
master
Choose a base branch
from
fix-morph-transform-interp
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
abe0bda
Fix Morph node transform interpolation and preservation in the table
Keavon a83c203
Fix click target positions for Morph's nested layers by pre-compensat…
Keavon b2f7cfb
Redesign Morph node (v3) with control path input and uniformly spaced…
Keavon d36770d
Add migration from Morph node v2 to v3
Keavon f50e736
Redesign the 'Blend Shapes' node behavior and subgraph definition
Keavon 8e2b175
Add the Layer > Blend menu entry to easily set up a blend
Keavon d6ebff5
Optimize the Morph node
Keavon 75ffed4
Refactor the Morph node to remove the roundtrip through BezPath
Keavon 798bc26
Fine-tune Morph node Bezier order promotion and handle interpolation
Keavon 8006668
Add the Layer > Morph menu bar entry
Keavon d393654
Fix NaN and guard against other potential NaN bugs breaking the editor
Keavon 1907486
Add InterpolationDistribution parameter to Morph with weighted progre…
Keavon 862811b
Add the Reverse parameter to the Morph node
Keavon 3a18737
Update the order of the inputs to Blend Shapes for consistency with M…
Keavon 00dc5d4
Make Layer > Morph create the Morph Path control layer
Keavon b675e40
Fix migrations
Keavon ba1ead9
Move 10 to a constant
Keavon 265341f
Avoid division by 0 in the Blend Shapes node internals
Keavon f24edc7
Rename nodes 'Blend' -> 'Mix' and 'Blend Shapes' to 'Blend'
Keavon d7904e3
Fix a crash encountered while testing
Keavon 06997c9
Final code review
Keavon 4eb9e8a
Make domain push dupe checks debug-only and use push_unchecked in the…
Keavon 30afd97
Pre-allocate for pushes to the vector domains
Keavon 74e814d
Add fast path at t=0
Keavon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,2 @@ | ||
| https://github.com/Keavon/graphite-branded-assets/archive/8ae15dc9c51a3855475d8cab1d0f29d9d9bc622c.tar.gz | ||
| c19abe4ac848f3c835e43dc065c59e20e60233ae023ea0a064c5fed442be2d3d | ||
| https://github.com/Keavon/graphite-branded-assets/archive/fc02baf37d7428e86aa0e5f772c1f6e42173d405.tar.gz | ||
| 061a880c753472ea0a84fbc09e54d3596bea6e299067169d34347c717de13ded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.