Desktop: Fix double-clicking top bar not toggling maximize in linux

[he1senbrg]

Before

maximize_before.mp4

After

maximize_after.mp4

Closes #3594

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves an issue where double-clicking the top bar on Linux systems failed to toggle window maximization. It introduces a pending_drag state to manage the initiation of window dragging, ensuring that the drag starts only after a mouse press and subsequent movement. This change corrects the behavior and aligns it with the intended functionality.

Highlights

• Fixes Double-Click Issue: This PR addresses a bug where double-clicking the top bar in Linux did not toggle window maximization as expected.
• Implements Pending Drag State: Introduces a pending_drag flag to handle the window drag action, ensuring it's triggered correctly after a mouse press and move.
• Refactors Window Drag Logic: Modifies the WindowDrag message handling to set the pending_drag flag and initiates the drag when the mouse moves, preventing immediate drag start.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[cubic-dev-ai]

No issues found across 1 file

Confidence score: 5/5

• Automated review surfaced no issues in the provided summaries.
• No files require special attention.

[gemini-code-assist]

Code Review

A pending_drag field was added to the App struct to handle window dragging. The WindowDrag event now sets pending_drag to true, and the actual drag operation is initiated in the PointerMoved event if pending_drag is true. The pending_drag flag is set to false when the left mouse button is released.