Render raster images as outlines in Outline mode#3831
Render raster images as outlines in Outline mode#3831YohYamasaki wants to merge 1 commit intoGraphiteEditor:masterfrom
Conversation
Summary of ChangesHello @YohYamasaki, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a significant enhancement to the rendering engine by enabling raster images to be displayed as simple outlines when the application is in 'Outline' mode. This change improves the visual clarity and performance for users working in this specific view, allowing them to focus on the structural layout of elements rather than their detailed content. The update ensures that raster images, whether CPU or GPU-backed, are represented consistently and efficiently as outlines, while also optimizing the blending process to avoid redundant operations. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces outlining for raster images in Outline mode. There's a logical inconsistency between the CPU and GPU implementations for when a blending layer is created, which could lead to different visual results. My review comments provide specific suggestions to address these points.
|
!build (Run ID 22387315862) |
|
* Draw a transformed unit-rectangle stroke instead of raster pixels * Skip creating blend layers for a raster image in Outline mode when only blend mode would trigger them
e7f186e to
12f7854
Compare
Closes #2888
Screencasts
Before
Screen.Recording.2026-02-25.at.08.04.18.mov
After
Screen.Recording.2026-02-25.at.07.59.43.mov
What changed
RenderMode::Outline, create a rectangle then apply the same transform as the other modes but without the image scaling factor as the rectangle is already an identity.Raster<CPU>andRaster<GPU>.Small notes
Just a tiny thing, but I kept the duplicated outline code for now for readability, happy to extract it into a shared helper if preferred.