-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Reimplement notice file generation for third-party licenses through Rust, now with CEF credits #3808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Reimplement notice file generation for third-party licenses through Rust, now with CEF credits #3808
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
95d689c
Reimplement third-party-licenses file generation
timon-schelling b0ef117
Add third-party-licenses to Nix build and use cleaner more flake cent…
timon-schelling 74122f9
Fix windows build
timon-schelling e9d75d6
Merge branch 'master' into cef-credits
timon-schelling 3e3ab32
Merge remote-tracking branch 'origin/master' into cef-credits
timon-schelling c8b55a7
Fixup
timon-schelling 3159878
Review
timon-schelling 3636487
Review
timon-schelling 7f5d579
fix shader ci
timon-schelling 1b265d4
Review
timon-schelling baa1ff0
review
timon-schelling f822bd1
Merge remote-tracking branch 'origin/master' into cef-credits
timon-schelling fe2aba5
fixup
timon-schelling 3ce12bd
Merge branch 'master' into cef-credits
Keavon e681dce
Review
timon-schelling db25f4c
nix fmt
timon-schelling File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,6 @@ | ||
| branding/ | ||
| target/ | ||
| third-party-licenses.txt* | ||
| result/ | ||
| .flatpak-builder/ | ||
| *.spv | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| { pkgs, inputs, ... }: | ||
| { pkgs, ... }: | ||
|
|
||
| let | ||
| extensions = [ | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P2:
info.cargoVendoredis defined but never used anywhere in the codebase. Either this should be consumed by downstream derivations (e.g., viainherit (info) cargoVendored;ingraphite.nix) or removed to avoid dead code and unnecessary evaluation.Prompt for AI agents