Fix solidify stroke node ignoring transforms applied before stroke node#3683
Merged
Keavon merged 2 commits intoGraphiteEditor:masterfrom Feb 15, 2026
Merged
Conversation
motherboardMage
changed the title
0HyperCube
approved these changes
Jan 26, 2026
Contributor
0HyperCube
left a comment
0HyperCube
left a comment
There was a problem hiding this comment.
Looks good; thanks for working on this fix.
Contributor
Author
|
Thanks for your help and insights @0HyperCube ! |
Keavon
force-pushed
the
fix-solidify-stroke
branch
from
7bccf0f to
c59c4f7
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where the Solidify Stroke node was ignoring transforms applied to strokes before the node. The fix applies the stroke's transform to the path before generating geometry and then reverses the transform on the result, ensuring that strokes with non-identity transforms (e.g., scale) are rendered correctly.
Changes:
- Modified the
solidify_strokefunction to applystroke.transformto bezier paths before stroke solidification - Applied the inverse transform to the solidified paths to return them to the original coordinate space
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Keavon
force-pushed
the
fix-solidify-stroke
branch
from
5072b6f to
bd4614f
Compare
Keavon
approved these changes
Feb 14, 2026
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Keavon
force-pushed
the
fix-solidify-stroke
branch
from
bd4614f to
dca9ee9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue raised in https://discord.com/channels/731730685944922173/881073965047636018/1416281986661613669
Solidify stroke now applies the stroke's transform to the path before generating geometry and then reverses the transform.
The rectangle on the left is 600px by 600px with transform scale at 1x and the one on the right is 100px by 100px with transform scale set to 6x on both axes.
Before
After
