Skip to content

Fixes the Path tool snapping to the X or Y axis with Shift held for handles (#2969)#3482

Open
Thunder-Blaze wants to merge 1 commit intoGraphiteEditor:masterfrom
Thunder-Blaze:fix-multi-handle-snapping
Open

Fixes the Path tool snapping to the X or Y axis with Shift held for handles (#2969)#3482
Thunder-Blaze wants to merge 1 commit intoGraphiteEditor:masterfrom
Thunder-Blaze:fix-multi-handle-snapping

Conversation

@Thunder-Blaze
Copy link
Copy Markdown

Description

  • Fixes the broken snap to X and Y axis logic when shift key is held

Issue

Closes #2969

Recording

recording_2025-12-17_02.10.03.online-video-cutter.com.mp4

@Keavon
Copy link
Copy Markdown
Member

Keavon commented Dec 16, 2025

Nice, thanks! Please comment in the issue that this fixes to link this PR.

@Keavon
Copy link
Copy Markdown
Member

Keavon commented Dec 16, 2025

!build

@github-actions
Copy link
Copy Markdown

📦 Build Complete for fbcb62f
https://2379778e.graphite.pages.dev

@Thunder-Blaze Thunder-Blaze force-pushed the fix-multi-handle-snapping branch from e0b9058 to 8bb8abc Compare December 16, 2025 21:26
@Thunder-Blaze
Copy link
Copy Markdown
Author

Sorry for the inconvenience, but will need !build once again @Keavon

@Keavon
Copy link
Copy Markdown
Member

Keavon commented Dec 16, 2025

!build

@github-actions
Copy link
Copy Markdown

📦 Build Complete for 8bb8abc
https://a2a71b25.graphite.pages.dev

@Thunder-Blaze
Copy link
Copy Markdown
Author

I guess, I found some errors in the current implementation, I'll fix them and update this

@Thunder-Blaze Thunder-Blaze force-pushed the fix-multi-handle-snapping branch 2 times, most recently from d4c2277 to 1a5faf4 Compare December 19, 2025 23:15
@Thunder-Blaze
Copy link
Copy Markdown
Author

Thunder-Blaze commented Dec 19, 2025

My current approach uses the already present snap function with some modifications to handle the snapping.
This seems to be working in all the cases I could think of, without breaking any existing functionality

recording_2025-12-20_04.47.56.mp4

@Ayush2k02
Copy link
Copy Markdown
Contributor

LGTM !

@Thunder-Blaze Thunder-Blaze force-pushed the fix-multi-handle-snapping branch 2 times, most recently from 9af5a5c to d5fd55f Compare February 20, 2026 21:41
@Keavon Keavon force-pushed the master branch 6 times, most recently from d6228da to e58c1de Compare March 16, 2026 23:03
@Keavon Keavon force-pushed the master branch 3 times, most recently from 05c5187 to fcc53f5 Compare March 19, 2026 09:26
@Keavon Keavon force-pushed the master branch 2 times, most recently from 9b97ab7 to 2e842cb Compare March 19, 2026 11:00
@Thunder-Blaze Thunder-Blaze force-pushed the fix-multi-handle-snapping branch from d5fd55f to c628fa2 Compare March 30, 2026 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Path tool snapping to the X or Y axis with Shift held is broken for handles

3 participants