Clarify that Kotlin's split(';') preserves trailing empty segments in mapName()#1969
Closed
Clarify that Kotlin's split(';') preserves trailing empty segments in mapName()#1969
split(';') preserves trailing empty segments in mapName()#1969Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Copilot
AI
changed the title
[WIP] [WIP] Address feedback on "Split relocators remapping" PR
Clarify that Kotlin's Mar 12, 2026
split(';') preserves trailing empty segments in mapName()
Goooler
force-pushed
the
copilot/sub-pr-1967-again
branch
from
37cc2f0 to
de214c1
Compare
…ts unlike Java Co-authored-by: Goooler <10363352+Goooler@users.noreply.github.com>
Goooler
force-pushed
the
copilot/sub-pr-1967-again
branch
from
de214c1 to
e1ba3c1
Compare
Member
|
There's no need to make a note of it; it's covered by the tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reviewer suggested using
split(';', limit = -1)to prevent trailing semicolons from being dropped in JVM descriptor strings. Investigation showed the suggested fix is invalid in Kotlin (IllegalArgumentException: Limit must be non-negative) and the concern itself doesn't apply — Kotlin'ssplit()with defaultlimit = 0already preserves trailing empty segments, unlike Java'sString.split().Relocators.kt: Replace the terse// Maybe a list of types.comment with one that explicitly documents the Kotlin vs Java split behavior, preventing future confusion about whether a "fix" is needed.Verified behavior:
Existing tests in
RelocatorsTest.kt(e.g."Lorg/package/ClassA;"→"Lshadow/org/package/ClassA;") already provide regression coverage.🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.