Fix skipStringConstants per-relocator behavior in mapName#1968
Merged
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Copilot
AI
changed the title
[WIP] [1902] Split relocators remapping
Fix skipStringConstants per-relocator behavior in mapName
Mar 12, 2026
Goooler
force-pushed
the
copilot/sub-pr-1967
branch
from
8e2af9a to
9bcb112
Compare
…of return Co-authored-by: Goooler <10363352+Goooler@users.noreply.github.com>
Goooler
force-pushed
the
copilot/sub-pr-1967
branch
from
9bcb112 to
39bbc6d
Compare
Goooler
approved these changes
Mar 12, 2026
1 task
Goooler
changed the title
skipStringConstants per-relocator behavior in mapName
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
skipStringConstants=trueon a relocator was incorrectly short-circuiting the entire relocator chain when mapping literals, instead of skipping only that specific relocator.Changes:
Relocators.kt: Changereturn name→continueinrealMaploop so a relocator withskipStringConstants=trueis skipped individually whenmapLiterals=true, allowing subsequent relocators to still match and applyRelocatorsTest.kt: AddskipStringConstantsIsPerRelocatortest covering the per-relocator skip semantics with deterministic iteration order vialinkedSetOf