Skip to content

[WIP] Apply patch #1139 for 8.x branch#1946

Closed
Copilot wants to merge 942 commits into8.xfrom
copilot/patch-1139-for-8-x
Closed

[WIP] Apply patch #1139 for 8.x branch#1946
Copilot wants to merge 942 commits into8.xfrom
copilot/patch-1139-for-8-x

Conversation

Copy link
Contributor

Copilot AI commented Mar 2, 2026

Thanks for asking me to work on this. I will get started on it and keep this PR's description up to date as I form a plan and make progress.

Patch #1139 for 8.x branch


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Goooler and others added 30 commits August 19, 2025 04:29
…is disabled (#1666)

* Return null for Int.MAX_VALUE

* Use provider

* Update changelog

* Test `dontInjectTargetJvmVersionWhenAutoTargetJvmDisabled`

* Don't pass null

* Revert "Don't pass null"

This reverts commit 541b5e4.

* Check and throw

* Use `afterEvaluate` and fix the test

* Cleanups
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* Allow for opt-out of the java shadowRuntimeElements variant

* Add `ShadowExtension.getAddOptionalJavaVariant`

* Test `publishShadowVariantJar`

* `mapToOptional` must be called in `afterEvaluate`

* Cleanups

* Fix merge

* Rename `addOptionalJavaVariant` to `addShadowVariantIntoJavaComponent`

* Document `Shadow Variant in Default Java Component`

* Update changelog

---------

Co-authored-by: Maximilian Müller <maxm123@techie.com>
* New `addTargetJvmVersionAttribute`

* Test `dontInjectTargetJvmVersionWhenOptingOut`

* Document the property

* Update docs/publishing/README.md

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* New `addMultiReleaseAttribute`

* Move the property into `ShadowJar`

* Test `doesNotContainMultiReleaseAttrIfDisabled`

* Parameterized test `containsMultiReleaseAttrIfAnyDependencyContainsIt`

* Test `containsMultiReleaseAttrByCliOption`

* Update CLI options

* Document `Adding Multi-Release Manifest Attribute`
* Tweak CLI option tests

* Add more logging

* Update info assertions

* Cleanups
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* Create indexed test dirs in provideDynamicTests

* With name

* Use `createDirectories`

* Note `displayName`

* Add `--stacktrace`

* Fix nonAlphanumeric names
* Remove `Automatic package relocation with Shadow prior to v8.1.0`

* Update `Automatically Relocating Dependencies`
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* Add example for `Shadow Configuration and Publishing`

* Remove `group` and `version`

* Remove `archiveClassifier`

* Reuse `retrofitVersion`

* Reword titles
* Document the short syntax and the full syntax for transforming

* Replace .class stuff with idiomatic Groovy call

* `Closure` to closure

* Merge `An instantiated instance of` part

* Use `enabled` property

* Fix ctor of `MyTransformer`
* Improvement: Write class bytes unmodified if possible.

If we don't need to make any changes to the class, we should use the original bytes instead of letting ASM generate new ones.
Some tools use class file bytes to determine if there are classpath conflicts, and the current approach leads to false positives.
Syncs with Goooler/maven-shade-plugin@146b87b.

* Cleanups

---------

Co-authored-by: Goooler <wangzongler@gmail.com>
)

* Mention `eachFile` and `filesNotMatching`

* New steps

* Use `ParameterizedTest` for `strategyCanBeOverriddenByEachFile`

* Cleanups

* Add more examples

* Merge duplicate steps

* Add the optional step at the last
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* Document minimizing sections a bit

* Mark issue 744 for `excludeProjectFromMinimize`

* Update docs/configuration/minimizing/README.md

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Comment Module descriptor

https://groovy-lang.org/metaprogramming.html#module-descriptor

* Add `GroovyResourceTransformer`

https://github.com/apache/maven-shade-plugin/blob/3409e5aed8b10d04f2de63af835c52058a834848/src/main/java/org/apache/maven/plugins/shade/resource/GroovyResourceTransformer.java

* Merge them and reduce legacy logic

* Test `mergeLegacyAndModernModuleDescriptorsIntoTheNewResourcePath`

* Use `ParameterizedTest`

* Update changelog

* Update docs/changes/README.md

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Cleanups

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Try to remove `afterEvaluate`

* Revert "Try to remove `afterEvaluate`"

This reverts commit 9aa3bc5.

* Comments
renovate bot and others added 20 commits February 13, 2026 18:43
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* Initial plan

* Sync changelog for main from 8.3.10 release

Co-authored-by: Goooler <10363352+Goooler@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: Goooler <10363352+Goooler@users.noreply.github.com>
* Initial plan

* warn on duplicate entries instead of info level logging

Co-authored-by: Goooler <10363352+Goooler@users.noreply.github.com>

* Update README with duplicate log warning details

Added a note about logging warnings for duplicates in the final JAR.

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: Goooler <10363352+Goooler@users.noreply.github.com>
Co-authored-by: Zongle Wang <wangzongler@gmail.com>
* Initial plan

* Fix issue 1932: Add @input annotations to relocation pattern fields in SimpleRelocator

Co-authored-by: Goooler <10363352+Goooler@users.noreply.github.com>

* Mark internal

* Update changelog

* Update src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/relocation/SimpleRelocator.kt

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/relocation/SimpleRelocator.kt

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: Goooler <10363352+Goooler@users.noreply.github.com>
Co-authored-by: Goooler <wangzongler@gmail.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* Initial plan

* Update CONTRIBUTING.md to mention updating Unreleased changelog section

Co-authored-by: Goooler <10363352+Goooler@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: Goooler <10363352+Goooler@users.noreply.github.com>
* Test `compatGradleArtifactTransform`

* Tweak `compatGradleArtifactTransform`

* Update `resolve`

* Call `project.provider`

* Update changelog

* Clean up test project

* Update docs/changes/README.md
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: Goooler <10363352+Goooler@users.noreply.github.com>
Co-authored-by: Goooler <wangzongler@gmail.com>
* Add IP flag for all tests

* First round

* Cleanups

* Update changelog

* New `Project.getApiJars`

* Reuse the config name

* Call `incoming.artifacts`
Updated git push command to use --follow-tags.
@Goooler Goooler changed the base branch from main to 8.x March 2, 2026 11:23
Copilot stopped work on behalf of Goooler due to an error March 2, 2026 11:24
@Goooler Goooler closed this Mar 2, 2026
@Goooler Goooler deleted the copilot/patch-1139-for-8-x branch March 2, 2026 11:27
Copilot stopped work on behalf of Goooler due to an error March 2, 2026 11:27
@Goooler
Copy link
Member

Goooler commented Mar 2, 2026

Addressed to #1947.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants