Skip to content

refactor(gnerative-ai): migrate batch 2 generative-ai samples to @google/genai#4331

Open
angelcaamal wants to merge 2 commits into
mainfrom
feat/migration-vertexai-genai-batch2
Open

refactor(gnerative-ai): migrate batch 2 generative-ai samples to @google/genai#4331
angelcaamal wants to merge 2 commits into
mainfrom
feat/migration-vertexai-genai-batch2

Conversation

@angelcaamal
Copy link
Copy Markdown
Contributor

@angelcaamal angelcaamal commented Jun 4, 2026

Description

Fixes Internal: b/519970318

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • Required CI tests pass (see CI testing)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

Note: Any check with (dev), (experimental), or (legacy) can be ignored and should not block your PR from merging (see CI testing).

@angelcaamal angelcaamal added samples Issues that are directly related to samples. generated: genai Contains Generative AI based code, requesting an additional reviewer. labels Jun 4, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request migrates several Gemini Node.js snippets from the legacy @google-cloud/vertexai SDK to the new @google/genai SDK, updating the default model to gemini-2.5-flash and enabling the corresponding test suites. Feedback was provided on gemini-translate.test.js to add a fallback value for process.env.LOCATION to prevent test failures when the environment variable is not set.

Comment thread generative-ai/snippets/test/gemini-translate.test.js Outdated
@angelcaamal angelcaamal marked this pull request as ready for review June 4, 2026 15:30
@angelcaamal angelcaamal requested review from a team as code owners June 4, 2026 15:30
@snippet-bot
Copy link
Copy Markdown

snippet-bot Bot commented Jun 4, 2026

Here is the summary of changes.

You are about to add 1 region tag.
You are about to delete 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

Copy link
Copy Markdown
Contributor

@amcolin amcolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look solid to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: genai generated: genai Contains Generative AI based code, requesting an additional reviewer. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants