Skip to content

chore(billing): migrate deprecated slack package to @slack/web-api#4281

Open
angelcaamal wants to merge 2 commits intoGoogleCloudPlatform:mainfrom
angelcaamal:chore/migrate-slack-billing
Open

chore(billing): migrate deprecated slack package to @slack/web-api#4281
angelcaamal wants to merge 2 commits intoGoogleCloudPlatform:mainfrom
angelcaamal:chore/migrate-slack-billing

Conversation

@angelcaamal
Copy link
Copy Markdown
Contributor

@angelcaamal angelcaamal commented Apr 10, 2026

Description

Fixes internal: b/414422540

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • Required CI tests pass (see CI testing)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

Note: Any check with (dev), (experimental), or (legacy) can be ignored and should not block your PR from merging (see CI testing).

@angelcaamal angelcaamal added the samples Issues that are directly related to samples. label Apr 10, 2026
@angelcaamal angelcaamal requested review from a team as code owners April 10, 2026 20:21
@product-auto-label product-auto-label bot added api: cloudbilling Issues related to the Cloud Billing API. api: cloudfunctions Issues related to the Cloud Run functions API. asset: pattern DEE Asset tagging - Pattern. labels Apr 10, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request replaces the deprecated slack package with the official @slack/web-api library in the billing function. A compatibility issue was identified where the new dependency requires Node.js 18 or higher, while the current project configuration allows Node.js 16, which could lead to runtime errors due to missing features like the global fetch API.

@product-auto-label product-auto-label bot removed the api: cloudfunctions Issues related to the Cloud Run functions API. label Apr 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: cloudbilling Issues related to the Cloud Billing API. asset: pattern DEE Asset tagging - Pattern. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant