chore(billing): migrate deprecated slack package to @slack/web-api#4281
Open
angelcaamal wants to merge 2 commits intoGoogleCloudPlatform:mainfrom
Open
chore(billing): migrate deprecated slack package to @slack/web-api#4281angelcaamal wants to merge 2 commits intoGoogleCloudPlatform:mainfrom
angelcaamal wants to merge 2 commits intoGoogleCloudPlatform:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request replaces the deprecated slack package with the official @slack/web-api library in the billing function. A compatibility issue was identified where the new dependency requires Node.js 18 or higher, while the current project configuration allows Node.js 16, which could lead to runtime errors due to missing features like the global fetch API.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes internal: b/414422540
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
npm test(see Testing)npm run lint(see Style)GoogleCloudPlatform/nodejs-docs-samples. Not a fork.