feat(storage): migrate HMAC key samples and tests#4269
feat(storage): migrate HMAC key samples and tests#4269angelcaamal wants to merge 2 commits intoGoogleCloudPlatform:mainfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the Google Cloud Storage Node.js samples by introducing a complete set of examples for managing HMAC keys. It provides developers with clear, executable code to perform various HMAC key operations, from creation to deletion, ensuring robust interaction with the Storage API. The inclusion of dedicated system tests guarantees the reliability and correctness of these new samples. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds several new sample files and tests for managing HMAC keys in Google Cloud Storage. The new samples demonstrate how to create, list, get, activate, deactivate, and delete HMAC keys.
My review focuses on improving code clarity and fixing a minor bug in a cleanup script. Specifically:
- In all the new sample files (
hmacKey*.js), I've suggested making themainfunctionasyncandawaiting the inner asynchronous function call. This is a best practice that makes the code's control flow easier to understand. - In the
storage/scripts/cleanupfile, I've identified a redundant API call and suggested a simplification of the promise chain for better readability and correctness.
The changes are otherwise well-structured and the tests are comprehensive.
Description
Fixes Internal: b/495528937
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
npm test(see Testing)npm run lint(see Style)GoogleCloudPlatform/nodejs-docs-samples. Not a fork.