Skip to content

feat(storage): migrate encryption samples and tests#4268

Draft
angelcaamal wants to merge 3 commits intoGoogleCloudPlatform:mainfrom
angelcaamal:encryption-storage-migration
Draft

feat(storage): migrate encryption samples and tests#4268
angelcaamal wants to merge 3 commits intoGoogleCloudPlatform:mainfrom
angelcaamal:encryption-storage-migration

Conversation

@angelcaamal
Copy link
Contributor

@angelcaamal angelcaamal commented Mar 23, 2026

Description

Fixes Internal: b/495529210

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • Required CI tests pass (see CI testing)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

Note: Any check with (dev), (experimental), or (legacy) can be ignored and should not block your PR from merging (see CI testing).

@angelcaamal angelcaamal added the samples Issues that are directly related to samples. label Mar 23, 2026
@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label Mar 23, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly expands the Google Cloud Storage Node.js samples by introducing a suite of new examples and corresponding system tests focused on various encryption scenarios. The additions cover key management, file operations with Customer-Supplied Encryption Keys (CSEK), and the migration of encryption types to Customer-Managed Encryption Keys (CMEK). This enhancement aims to provide developers with robust, tested code examples for implementing secure storage solutions.

Highlights

  • New Encryption Samples: Introduced a comprehensive set of new samples for Google Cloud Storage encryption operations, covering key generation, uploading, downloading, and rotating files with Customer-Supplied Encryption Keys (CSEK).
  • CSEK to CMEK Conversion: Added a new sample demonstrating the conversion of a file from Customer-Supplied Encryption Key (CSEK) to Customer-Managed Encryption Key (CMEK).
  • System Tests: Implemented robust system tests to validate the functionality and correctness of all new encryption samples.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request migrates several encryption-related samples and their corresponding tests. The new samples are a great addition. However, I've found a few critical bugs in the sample code and tests that need to be addressed. These include incorrect API usage for key rotation, flawed logic in a system test that fetches metadata for the wrong file, and incorrect default parameter values that would cause samples to fail. I've provided specific comments and suggestions for fixes below.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the Cloud Storage API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant