feat(storage): migrate encryption samples and tests#4268
feat(storage): migrate encryption samples and tests#4268angelcaamal wants to merge 3 commits intoGoogleCloudPlatform:mainfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly expands the Google Cloud Storage Node.js samples by introducing a suite of new examples and corresponding system tests focused on various encryption scenarios. The additions cover key management, file operations with Customer-Supplied Encryption Keys (CSEK), and the migration of encryption types to Customer-Managed Encryption Keys (CMEK). This enhancement aims to provide developers with robust, tested code examples for implementing secure storage solutions. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request migrates several encryption-related samples and their corresponding tests. The new samples are a great addition. However, I've found a few critical bugs in the sample code and tests that need to be addressed. These include incorrect API usage for key rotation, flawed logic in a system test that fetches metadata for the wrong file, and incorrect default parameter values that would cause samples to fail. I've provided specific comments and suggestions for fixes below.
Description
Fixes Internal: b/495529210
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
npm test(see Testing)npm run lint(see Style)GoogleCloudPlatform/nodejs-docs-samples. Not a fork.