feat(storage): migrate files samples and tests#4266
feat(storage): migrate files samples and tests#4266angelcaamal wants to merge 2 commits intoGoogleCloudPlatform:mainfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly expands the Google Cloud Storage Node.js samples by introducing a wide array of file manipulation functionalities. It provides new examples for common and advanced file operations, including various upload and download methods, file lifecycle management, and security features like signed URLs and object retention. The changes are accompanied by extensive system tests to validate the implementation of these new samples, ensuring their reliability and correctness. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces numerous new Node.js samples for Google Cloud Storage operations, covering file management (compose, copy, delete, download, move, rename), metadata handling, signed URL generation, object retention, and soft deletion. The package.json has been updated with new dependencies. The review comments highlight several areas for improvement: the cleanup script has issues with promise chaining and error handling, streamFileDownload.js and streamFileUpload.js contain race conditions and incorrect error handling due to improper await usage with streams, and downloadFile.js and uploadFileWithKmsKey.js have redundant error catching.
Description
Fixes Internal: b/495532924
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
npm test(see Testing)npm run lint(see Style)GoogleCloudPlatform/nodejs-docs-samples. Not a fork.