-
Notifications
You must be signed in to change notification settings - Fork 2k
feat(storage): migrate quickstart sample and tests #4264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
angelcaamal
merged 5 commits into
GoogleCloudPlatform:main
from
angelcaamal:quickstart-storage-migration
Mar 27, 2026
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
d79165f
feat(storage): introduce quickstart sample and test for migration
angelcaamal 60b2cb2
test(storage): fix quickstart system test
angelcaamal 39e2afa
Merge branch 'main' into quickstart-storage-migration
angelcaamal dbdd149
Merge branch 'main' into quickstart-storage-migration
iennae 4c16018
Merge branch 'main' into quickstart-storage-migration
angelcaamal File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| // Copyright 2019 Google LLC | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| 'use strict'; | ||
|
|
||
| function main(bucketName = 'my-new-bucket') { | ||
| // [START storage_quickstart] | ||
| // Imports the Google Cloud client library | ||
| const {Storage} = require('@google-cloud/storage'); | ||
|
|
||
| // For more information on ways to initialize Storage, please see | ||
| // https://googleapis.dev/nodejs/storage/latest/Storage.html | ||
|
|
||
| // Creates a client using Application Default Credentials | ||
| const storage = new Storage(); | ||
|
|
||
| // Creates a client from a Google service account key | ||
| // const storage = new Storage({keyFilename: 'key.json'}); | ||
|
|
||
| /** | ||
| * TODO(developer): Uncomment these variables before running the sample. | ||
| */ | ||
| // The ID of your GCS bucket | ||
| // const bucketName = 'your-unique-bucket-name'; | ||
|
|
||
| async function createBucket() { | ||
| try { | ||
| // Creates the new bucket | ||
| await storage.createBucket(bucketName); | ||
| console.log(`Bucket ${bucketName} created.`); | ||
| } catch (error) { | ||
| console.error('Error executing create bucket:', error.message || error); | ||
| } | ||
| } | ||
|
|
||
| createBucket(); | ||
| // [END storage_quickstart] | ||
| } | ||
|
|
||
| main(...process.argv.slice(2)); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| // Copyright 2019 Google LLC | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| 'use strict'; | ||
|
|
||
| const {assert} = require('chai'); | ||
| const {after, it} = require('mocha'); | ||
| const cp = require('child_process'); | ||
| const uuid = require('uuid'); | ||
| const {Storage} = require('@google-cloud/storage'); | ||
|
|
||
| const execSync = cmd => cp.execSync(cmd, {encoding: 'utf-8'}); | ||
|
|
||
| const storage = new Storage(); | ||
| const bucketName = `nodejs-storage-samples-${uuid.v4()}`; | ||
|
|
||
| after(async () => { | ||
| const bucket = storage.bucket(bucketName); | ||
| await bucket.delete({force: true}).catch(console.error); | ||
| }); | ||
|
|
||
| it('should run the quickstart', async () => { | ||
| const stdout = execSync(`node quickstart ${bucketName}`); | ||
| assert.match(stdout, /Bucket .* created./); | ||
| }); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.