feat(storage): migrate bucket samples and tests#4262
feat(storage): migrate bucket samples and tests#4262angelcaamal wants to merge 2 commits intoGoogleCloudPlatform:mainfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the Google Cloud Storage Node.js samples by introducing a wide array of new examples for managing GCS buckets. The additions cover fundamental operations as well as advanced configurations, providing developers with robust and practical code snippets. Accompanying these samples are new system tests to validate their functionality, ensuring high quality and reliability. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a comprehensive suite of new Node.js samples for Google Cloud Storage bucket management, covering various operations such as creating specialized buckets (e.g., dual-region, hierarchical namespace, object retention, with specific storage classes and locations), and managing bucket metadata like labels, CORS, website configurations, versioning, default KMS keys, uniform bucket-level access, public access prevention, RPO, soft delete policies, and autoclass settings. The changes also include updates to package.json, .gitignore, and test resources. Review comments indicate a bug in system-test/buckets.test.js where a test for hierarchical namespace bucket creation incorrectly asserts properties of a different bucket, and an improvement opportunity in storage/scripts/cleanup to simplify a redundant and complex promise chain for deleting files and buckets.
Description
Fixes Internal: b/495409887
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
npm test(see Testing)npm run lint(see Style)GoogleCloudPlatform/nodejs-docs-samples. Not a fork.