Skip to content

refactor(jobs): Remove quickstart duplicated region tag#10304

Merged
amcolin merged 1 commit into
mainfrom
refactor(jobs)_remove_quickstart_duplicated_regiontag
Jul 14, 2026
Merged

refactor(jobs): Remove quickstart duplicated region tag#10304
amcolin merged 1 commit into
mainfrom
refactor(jobs)_remove_quickstart_duplicated_regiontag

Conversation

@Kef131

@Kef131 Kef131 commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Description

Fixes #
b/347826002

Removed quickstart middle step process on the rename in jobs/v3/src/main/java/com/google/samples/JobServiceQuickstart.java

Checklist

Testing

  • I have tested this change on a live environment and verified it works as intended.
  • Tests pass: mvn clean verify required
  • Lint passes: mvn -P lint checkstyle:check required
  • Static Analysis: mvn -P lint clean compile pmd:cpd-check spotbugs:check advisory only

Compliance & Style

  • I have followed Sample Format Guide
  • pom.xml parent set to latest shared-configuration
  • Appropriate changes to README are included in PR
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample

Post-Approval Actions

  • Please merge this PR for me once it is approved

@Kef131 Kef131 self-assigned this Jul 13, 2026
@product-auto-label product-auto-label Bot added api: jobs Issues related to the Cloud Talent Solution Job Search API. samples Issues that are directly related to samples. labels Jul 13, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the redundant 'quickstart' region tags from the JobServiceQuickstart class, leaving only the 'job_search_quick_start' tags. There are no review comments, and I have no additional feedback to provide.

@XrossFox XrossFox left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@amcolin amcolin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amcolin amcolin marked this pull request as ready for review July 14, 2026 00:12
@amcolin amcolin requested review from a team and yoshi-approver as code owners July 14, 2026 00:12
@snippet-bot

snippet-bot Bot commented Jul 14, 2026

Copy link
Copy Markdown

Here is the summary of changes.

You are about to delete 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@amcolin amcolin merged commit 3626087 into main Jul 14, 2026
15 checks passed
@amcolin amcolin deleted the refactor(jobs)_remove_quickstart_duplicated_regiontag branch July 14, 2026 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: jobs Issues related to the Cloud Talent Solution Job Search API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants