Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main-design-system #91 +/- ##
=====================================================
Coverage ? 26.46%
=====================================================
Files ? 146
Lines ? 5211
Branches ? 0
=====================================================
Hits ? 1379
Misses ? 3832
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Submit a pull request
CLA
Description of the pull request
This updates our icon set. Besides bringing this to the latest icon set it also adds a log with some logic to preserve codePoints.
A code point is basically the location of an icon in the font file. With with a regular alphabet you could have A = 1, B = 2, C = 3. Etc. In code you would refer to the letter B as point 2. If you add a letter before this, for example a $ you would get $ = 1, A = 2, B = 3, C = 4. So the code that refers to letter B will now refer to point 3. However, in web sometimes the font file is being cached, which means that while using that old font file the codePoint 3 will actually draw a C. This log will ensure that new icons are always added at the end of the list, but doesn't make it any more complicated for us to update the full set.
The gallery draws all the icons the same size. That's something that could be improved by also generating the sizes for the icons in some list.
Screenshots / Videos