Skip to content

feat(ui): update icon set#91

Open
renefloor wants to merge 4 commits intomain-design-systemfrom
feature/update-icon-set
Open

feat(ui): update icon set#91
renefloor wants to merge 4 commits intomain-design-systemfrom
feature/update-icon-set

Conversation

@renefloor
Copy link
Copy Markdown
Collaborator

Submit a pull request

CLA

  • I have signed the Stream CLA (required).
  • The code changes follow best practices
  • Code changes are tested (add some information if not applicable)

Description of the pull request

This updates our icon set. Besides bringing this to the latest icon set it also adds a log with some logic to preserve codePoints.

A code point is basically the location of an icon in the font file. With with a regular alphabet you could have A = 1, B = 2, C = 3. Etc. In code you would refer to the letter B as point 2. If you add a letter before this, for example a $ you would get $ = 1, A = 2, B = 3, C = 4. So the code that refers to letter B will now refer to point 3. However, in web sometimes the font file is being cached, which means that while using that old font file the codePoint 3 will actually draw a C. This log will ensure that new icons are always added at the end of the list, but doesn't make it any more complicated for us to update the full set.

The gallery draws all the icons the same size. That's something that could be improved by also generating the sizes for the icons in some list.

Screenshots / Videos

image

@renefloor renefloor requested a review from a team as a code owner March 31, 2026 14:57
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 31, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: c6cc15e7-4481-4b82-9553-486191625315

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/update-icon-set

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@renefloor renefloor changed the title Feature/update icon set feat(ui): update icon set Mar 31, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 31, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main-design-system@6d9e79b). Learn more about missing BASE report.

Additional details and impacted files
@@                  Coverage Diff                  @@
##             main-design-system      #91   +/-   ##
=====================================================
  Coverage                      ?   26.46%           
=====================================================
  Files                         ?      146           
  Lines                         ?     5211           
  Branches                      ?        0           
=====================================================
  Hits                          ?     1379           
  Misses                        ?     3832           
  Partials                      ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant