Skip to content

fix(interop): unwrap CJS default exports (react-player, @emoji-mart/react) #3199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oliverlaz merged 2 commits into from
May 27, 2026
Merged

fix(interop): unwrap CJS default exports (react-player, @emoji-mart/react) #3199

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
54bf3b0
fix(VideoPlayer): unwrap react-player CJS default export
oliverlaz May 27, 2026
0417c7f
fix(EmojiPicker): unwrap @emoji-mart/react CJS default export
oliverlaz May 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion src/components/VideoPlayer/VideoPlayer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,16 @@
import { useComponentContext } from '../../context';
import ReactPlayer from 'react-player';
import ReactPlayerImport from 'react-player';
import React from 'react';

// react-player ships as CJS with the component on `exports.default`. Some
// bundler/interop setups (e.g. Vite serving our built ESM as a linked workspace
// dependency) hand back the module namespace `{ default }` instead of the
// component itself, which makes React throw "Element type is invalid ... got:
// object". Unwrap the default defensively so it works regardless of interop.
const ReactPlayer =
(ReactPlayerImport as unknown as { default?: typeof ReactPlayerImport }).default ??
ReactPlayerImport;

export type VideoPlayerProps = {
isPlaying?: boolean;
videoUrl?: string;
Expand Down
10 changes: 9 additions & 1 deletion src/plugins/Emojis/EmojiPicker.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import React, { useEffect, useState } from 'react';
import Picker from '@emoji-mart/react';
import PickerImport from '@emoji-mart/react';

import { useMessageComposerContext, useTranslationContext } from '../../context';
import {
Expand All @@ -11,6 +11,14 @@ import {
import { usePopoverPosition } from '../../components/Dialog/hooks/usePopoverPosition';
import { useIsCooldownActive } from '../../components/MessageComposer/hooks/useIsCooldownActive';

// @emoji-mart/react ships as CJS with the component on `exports.default`. Under
// spec-strict ESM interop (e.g. Vite 8 / Rolldown, native Node ESM) a default
// import yields the module namespace `{ default }` instead of the component,
// which makes React throw "Element type is invalid ... got: object". Unwrap the
// default defensively so it works regardless of interop.
const Picker =
(PickerImport as unknown as { default?: typeof PickerImport }).default ?? PickerImport;

const isShadowRoot = (node: Node): node is ShadowRoot => !!(node as ShadowRoot).host;

export type EmojiPickerProps = {
Expand Down