feat: redesign image loading and error placeholders#3000
Merged
Conversation
oliverlaz
changed the title
|
Size Change: +1.23 kB (+0.29%) Total Size: 429 kB
ℹ️ View Unchanged
|
oliverlaz
changed the title
oliverlaz
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Implement the REACT-834 media placeholder redesign for message attachments so image thumbnails handle both loading and failed-load states without causing layout jumps.
🛠 Implementation details
ModalGallerywith an inline retry control that remounts the image for a fresh load attempt instead of opening the galleryBaseImage's download fallback optional and disable it for this message-thumbnail surface so the retry indicator is the only error treatment shown hereBaseImageandModalGallerytests to cover preserved sizing, loading overlays, retry remount behavior, and suppression of the legacy download fallback🎨 UI Changes
Design reference: https://linear.app/stream/issue/REACT-834/redesign-image-placeholder-for-failed-to-load-images
Screen.Recording.2026-03-11.at.15.43.25.mov
Incoming and outgoing image attachment bubbles now reserve their final size immediately, show a shimmer plus centered loading indicator while media is loading, and swap to the reload indicator inside the same area when loading fails.