fix: wrap attachment previews in message composer#2994
Merged
Conversation
|
Size Change: +81 B (+0.02%) Total Size: 427 kB
ℹ️ View Unchanged
|
…unnecessary changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Make attachment previews in the message composer wrap onto new lines instead of forcing a horizontal scroll area, so the composer grows with its content for mouse users.
Linear ticket: https://linear.app/stream/issue/REACT-841/make-attachment-preview-container-grow-horizontally
🛠 Implementation details
attachment-preview-listtest hook and update the related tests and snapshotyarn build-styling, targetedAttachmentPreviewListtests, andprettier --checkMessageInput.test.jscoverage is currently failing in this branch before attachment assertions becauseuseMediaRecorderresolvesuseMessageComposeras non-functional🎨 UI Changes
No screenshots attached from the CLI environment. This is a composer layout change: attachment previews now wrap to new rows and the input grows vertically instead of showing a horizontal preview scrollbar.