fix: remove Channel component propagation#2904
Merged
arnautov-anton merged 2 commits intomasterfrom Feb 3, 2026
Merged
Conversation
arnautov-anton
requested review from
MartinCupela and
oliverlaz
as code owners
|
Size Change: 0 B Total Size: 316 kB ℹ️ View Unchanged
|
oliverlaz
approved these changes
Jan 8, 2026
Member
oliverlaz
left a comment
oliverlaz
left a comment
There was a problem hiding this comment.
Good to adjust the docs too
Contributor
Author
Yes, that's the next step as discussed earlier. :) |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2904 +/- ##
==========================================
- Coverage 80.05% 79.97% -0.08%
==========================================
Files 511 511
Lines 10803 10802 -1
Branches 2711 2711
==========================================
- Hits 8648 8639 -9
- Misses 1902 1910 +8
Partials 253 253 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
MartinCupela
reviewed
Jan 9, 2026
| <ChatView.Selector /> | ||
| <ChatView.Channels> | ||
| <ChannelList | ||
| Avatar={ChannelAvatar} |
Contributor
There was a problem hiding this comment.
@arnautov-anton don't we want to apply the same logic to ChannelList? I mean to not to allow passing Components as props and force the use of WithComponents.
Contributor
Author
There was a problem hiding this comment.
Good point, I can adjust the PR to include .ChannelList too
Edit: I'll open up separate PR to include renames to the ChannelList-related components.
MartinCupela
approved these changes
Jan 9, 2026
arnautov-anton
force-pushed
the
fix/remove-channel-component-propagation
branch
2 times, most recently
from
0387026 to
9f8b99d
Compare
arnautov-anton
force-pushed
the
fix/remove-channel-component-propagation
branch
2 times, most recently
from
8a04000 to
79568f3
Compare
arnautov-anton
force-pushed
the
fix/remove-channel-component-propagation
branch
from
79568f3 to
4dc6419
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Use the capabilities of
WithComponentsto propagate component overrides, do not useChannelas a proxy.BREAKING CHANGE:
Channelcomponent no longer supports component overrides, useWithComponentsinstead.