Skip to content

fix: badge count positioning wrt to other elements in parent #3465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
khushal87 merged 4 commits into from
Mar 6, 2026
+145 −125
Merged

fix: badge count positioning wrt to other elements in parent #3465

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4ff79a2
fix: badge count positioning wrt to other elements in parent
khushal87 Mar 6, 2026
1733848
fix: badge count positioning wrt to other elements in parent
khushal87 Mar 6, 2026
ba420a8
fix: badge sizes
khushal87 Mar 6, 2026
c832761
fix: badge sizes
khushal87 Mar 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions package/src/components/Message/MessageSimple/MessageReplies.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,8 +221,6 @@ const useStyles = () => {
alignItems: 'center',
flexDirection: 'row',
gap: primitives.spacingXs,
paddingTop: primitives.spacingXs,
paddingBottom: primitives.spacingXxs,
},
messageRepliesText: {
color: shouldUseOverlayStyles ? semantics.textOnAccent : semantics.textPrimary,
Expand Down
189 changes: 99 additions & 90 deletions package/src/components/MessageList/__tests__/__snapshots__/TypingIndicator.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,134 +27,143 @@ exports[`TypingIndicator should match typing indicator snapshot 1`] = `
>
<View
style={
[
{
"alignItems": "center",
"flexDirection": "row",
},
{
"width": 51.2,
},
]
{
"flexDirection": "row",
}
}
>
<View
style={
[
{
"position": "absolute",
"alignItems": "center",
"flexDirection": "row",
},
{
"left": 0,
"height": 32,
"width": 51.2,
},
]
}
>
<View
testID="user-avatar"
style={
[
{
"position": "absolute",
},
{
"left": 0,
},
]
}
>
<View
style={
[
{
"alignItems": "center",
"borderRadius": 9999,
"justifyContent": "center",
"overflow": "hidden",
},
{
"height": 32,
"width": 32,
},
{
"backgroundColor": "#fcd579",
},
{
"borderColor": "rgba(0, 0, 0, 0.1)",
"borderWidth": 1,
},
undefined,
]
}
testID="avatar-image"
testID="user-avatar"
>
<Image
onError={[Function]}
source={
{
"uri": "https://i.imgur.com/LuuGvh0.png",
}
}
<View
style={
[
{},
{
"alignItems": "center",
"borderRadius": 9999,
"justifyContent": "center",
"overflow": "hidden",
},
{
"height": 32,
"width": 32,
},
{
"backgroundColor": "#fcd579",
},
{
"borderColor": "rgba(0, 0, 0, 0.1)",
"borderWidth": 1,
},
undefined,
]
}
/>
testID="avatar-image"
>
<Image
onError={[Function]}
source={
{
"uri": "https://i.imgur.com/LuuGvh0.png",
}
}
style={
[
{},
{
"height": 32,
"width": 32,
},
]
}
/>
</View>
</View>
</View>
</View>
<View
style={
[
{
"position": "absolute",
},
{
"left": 19.2,
},
]
}
>
<View
testID="user-avatar"
style={
[
{
"position": "absolute",
},
{
"left": 19.2,
},
]
}
>
<View
style={
[
{
"alignItems": "center",
"borderRadius": 9999,
"justifyContent": "center",
"overflow": "hidden",
},
{
"height": 32,
"width": 32,
},
{
"backgroundColor": "#8febbd",
},
{
"borderColor": "rgba(0, 0, 0, 0.1)",
"borderWidth": 1,
},
undefined,
]
}
testID="avatar-image"
testID="user-avatar"
>
<Image
onError={[Function]}
source={
{
"uri": "https://i.imgur.com/spueyAP.png",
}
}
<View
style={
[
{},
{
"alignItems": "center",
"borderRadius": 9999,
"justifyContent": "center",
"overflow": "hidden",
},
{
"height": 32,
"width": 32,
},
{
"backgroundColor": "#8febbd",
},
{
"borderColor": "rgba(0, 0, 0, 0.1)",
"borderWidth": 1,
},
undefined,
]
}
/>
testID="avatar-image"
>
<Image
onError={[Function]}
source={
{
"uri": "https://i.imgur.com/spueyAP.png",
}
}
style={
[
{},
{
"height": 32,
"width": 32,
},
]
}
/>
</View>
</View>
</View>
</View>
Expand Down
79 changes: 46 additions & 33 deletions package/src/components/ui/Avatar/AvatarStack.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import { UserAvatar } from './UserAvatar';
import { BadgeCount } from '../Badge';

export type AvatarStackProps = {
avatarSize?: 'sm' | 'md' | 'xs';
avatarSize?: 'md' | 'sm' | 'xs';
maxVisible?: number;
items: React.ReactNode[];
overlap?: number;
Expand All @@ -24,41 +24,50 @@ export const AvatarStack = (props: AvatarStackProps) => {
const visibleItems = items.slice(0, maxVisible);
const extraCount = items.length - visibleItems.length;

if (extraCount > 0) {
visibleItems.push(
<BadgeCount
count={extraCount}
size={avatarSize === 'sm' || avatarSize === 'md' ? 'md' : 'sm'}
/>,
);
}

const totalWidth = diameter + (visibleItems.length - 1) * visiblePortion;

const badgeCountSize = avatarSize === 'md' ? 'lg' : avatarSize === 'sm' ? 'md' : 'sm';

return (
<View
style={[
styles.container,
{
width: totalWidth,
},
]}
>
{visibleItems.map((item, index) => {
return (
<View
style={[
styles.item,
{
left: index * visiblePortion,
},
]}
key={index}
>
{item}
</View>
);
})}
<View style={styles.wrapper}>
<View
style={[
styles.container,
{
width: totalWidth,
height: diameter,
},
]}
>
{visibleItems.map((item, index) => {
return (
<View
style={[
styles.item,
{
left: index * visiblePortion,
},
]}
key={index}
>
{item}
</View>
);
})}
</View>

{extraCount > 0 && (
<View
style={[
styles.badgeCount,
{
marginLeft: -(overlap * diameter),
},
]}
>
<BadgeCount count={extraCount} size={badgeCountSize} />
</View>
)}
</View>
);
};
Expand Down Expand Up @@ -100,6 +109,10 @@ const useStyles = () => {
item: {
position: 'absolute',
},
badgeCount: {},
wrapper: {
flexDirection: 'row',
},
}),
[],
);
Expand Down