feat: poll ui in message view #3392
Conversation
SDK Size
|
| {!isClosed && allowUserSuggestedOptions ? ( | ||
| <GenericPollButton onPress={onPressHandler} title={t('Suggest an option')} /> | ||
| <Button | ||
| variant='secondary' |
There was a problem hiding this comment.
instead of using Button everywhere with the same configuration, you can extend GenericPollButton since it already provides all of the necessary properties. At least for the ones that are the same. For the End Vote one you can do it separately
There was a problem hiding this comment.
You mean use the Button inside GenericPollButton?
There was a problem hiding this comment.
Yes. Since it's the same everywhere. That's also useful if integrators want to add their own buttons (we provide our default). Otherwise they can do it themselves of course
| * React hook to check if the poll was created by the logged in client. | ||
| * @returns Whether the poll was created by the logged in client. | ||
| */ | ||
| export const useIsPollCreatedByClient = () => { |
There was a problem hiding this comment.
| export const useIsPollCreatedByClient = () => { | |
| export const useIsPollCreatedByCurrentUser = () => { |
| <View | ||
| style={[styles.container, { backgroundColor: emptyColor }]} | ||
| onLayout={({ nativeEvent }) => { | ||
| setWidth(nativeEvent.layout.width); |
There was a problem hiding this comment.
You can achieve the same by playing with flex, as it was before. You won't need to rely on onLayout, nor on setting state when it happens and consequently rerendering this needlessly.
In other words, let yoga handle it.
isekovanic
left a comment
isekovanic
left a comment
There was a problem hiding this comment.
Please have a look at the couple of comments I left here, other than that looks good
3 participants
This pull request introduces a comprehensive refactor of poll-related UI components to improve consistency, accessibility, and maintainability. The changes focus on replacing custom button components with standardized UI buttons, updating styles to use theme primitives, and enhancing the visual presentation of poll options and results. Additionally, a new hook is introduced to determine poll ownership, which is leveraged for dynamic styling.
UI Component Refactoring:
GenericPollButtonin poll components with the standardizedButtoncomponent, ensuring consistent appearance and behavior across poll actions such as viewing results, ending the vote, suggesting options, and adding comments. [1] [2] [3] [4] [5] [6]UserAvatarStackfor displaying voters andProgressBarfor vote progress, improving clarity and visual feedback. [1] [2]PollButtonslayout to group buttons in a container with improved spacing and dynamic border colors based on poll ownership.Styling and Theming Enhancements:
useStyleshooks in poll components to centralize and memoize style definitions, including dynamic styling based on poll ownership. [1] [2] [3]New Utility Hook:
useIsPollCreatedByClienthook to determine if the poll was created by the current user, enabling conditional styling and logic in poll components. [1] [2] [3]These changes collectively modernize the poll UI, improve maintainability, and enable richer theming and accessibility.