Draft
Conversation
…e across process death and synchronize external attachments. - Implement `SavedStateHandle` persistence for selected URIs, grid attachments, and external attachments (camera/system picker). - Add `addExternalAttachments` and `removeExternalAttachment` to manage one-shot attachment sources. - Update `getSelectedAttachments` to serve as the single source of truth for the message composer. - Ensure `clearSelection` resets all persisted picker state. - Change default `GalleryPickerMode` and `FilePickerMode` to single selection.
…ckerViewModel` and `MessageComposerViewModel`. - Shift responsibility for the master list of staged attachments from `AttachmentsPickerViewModel` to `MessageComposerViewModel`, making the latter the single source of truth for message attachments. - Implement state persistence for selected attachments in `MessageComposerViewModel` using `SavedStateHandle` to survive Activity recreation. - Update `AttachmentsPickerViewModel` to only manage grid selection state (URI-based checkmarks) and storage browsing. - Refactor `AttachmentPickerActions` to coordinate selection between the picker (grid UI) and the composer (staged list). - Rename attachment manipulation methods in `MessageComposerViewModel` to `addAttachments`, `removeAttachment`, and `clearAttachments`. - Update `MessagesViewModelFactory` to provide `SavedStateHandle` to the composer and picker ViewModels.
…tions across process death
Contributor
PR checklist ❌The following issues were detected:
What we check
|
Contributor
SDK Size Comparison 📏
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Describe why we are making this change
Implementation
Describe the implementation
🎨 UI Changes
Add relevant screenshots
Add relevant videos
Testing
Explain how this change can be tested (or why it can't be tested)
Provide a patch below if it is necessary for testing
Provide the patch summary here