Skip to content

feat(MedialBallsExtractor): mutex in ray tracing #1282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BotellaA merged 1 commit into from
Jun 3, 2026
+9 −2
Merged

feat(MedialBallsExtractor): mutex in ray tracing #1282

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions src/geode/model/helpers/ray_tracing.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@

#include <geode/model/helpers/ray_tracing.hpp>

#include <absl/synchronization/mutex.h>

#include <geode/basic/pimpl_impl.hpp>

#include <geode/geometry/aabb.hpp>
Expand All @@ -41,7 +43,7 @@
namespace
{
constexpr geode::index_t NUMBER_2D_DIRECTIONS = 9;
const std::array< geode::Vector2D, NUMBER_2D_DIRECTIONS >& directions_2D()

Check warning on line 46 in src/geode/model/helpers/ray_tracing.cpp

View workflow job for this annotation

GitHub Actions / test / tidy

src/geode/model/helpers/ray_tracing.cpp:46:64 [readability-identifier-naming] 

invalid case style for function 'directions_2D'
{
static const std::array< geode::Vector2D, NUMBER_2D_DIRECTIONS >
directions = { {
Expand All @@ -59,7 +61,7 @@
}

constexpr geode::index_t NUMBER_3D_DIRECTIONS = 13;
const std::array< geode::Vector3D, NUMBER_3D_DIRECTIONS >& directions_3D()

Check warning on line 64 in src/geode/model/helpers/ray_tracing.cpp

View workflow job for this annotation

GitHub Actions / test / tidy

src/geode/model/helpers/ray_tracing.cpp:64:64 [readability-identifier-naming] 

invalid case style for function 'directions_3D'
{
static const std::array< geode::Vector3D, NUMBER_3D_DIRECTIONS >
directions = { {
Expand Down Expand Up @@ -298,10 +300,14 @@
private:
const AABBTree3D& surface_aabb( const Surface3D& surface )
{
if( aabb_trees_.contains( surface.id() ) )
{
return aabb_trees_.at( surface.id() );
absl::ReaderMutexLock read_lock{ mutex_ };
if( aabb_trees_.contains( surface.id() ) )
{
return aabb_trees_.at( surface.id() );
}
}
absl::MutexLock lock{ mutex_ };
return aabb_trees_
.emplace( surface.id(), create_aabb_tree( surface.mesh() ) )
.first->second;
Expand All @@ -310,6 +316,7 @@
private:
const BRep& brep_;
absl::flat_hash_map< uuid, AABBTree3D > aabb_trees_;
absl::Mutex mutex_;
};

BRepRayTracing::BRepRayTracing( const BRep& brep ) : impl_{ brep } {}
Expand Down
Loading