Container user linuxgsm crontab can be saved optionally#94
Open
WildPenquin wants to merge 1 commit intoGameServerManagers:mainfrom
Open
Container user linuxgsm crontab can be saved optionally#94WildPenquin wants to merge 1 commit intoGameServerManagers:mainfrom
WildPenquin wants to merge 1 commit intoGameServerManagers:mainfrom
Conversation
Author
|
I've noticed there used to be similar pull requests previously. However this one is more simple and sometimes setting a crontab within the container is a requested feature. I don't personally need it and I understand if this is not desired for some reason (keeping the Dockerfile simple?). This will save the crontab in |
This should be transparent to users and requires no intervention if they do not wish to use a custom crontab. Current behavior is retained. To actually use the custom crontab, the user needs to set LGSM_SAVE_CRONTAB to true. If set to false, the container will function exactly as it functions now. This variable needs to be documented in the downstream (docker image) repository.
Author
|
This would fix GameServerManagers/LinuxGSM#4584 . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should be transparent to users and requires no intervention if they do not wish to use a custom crontab. Current behavior is retained.
To actually use the custom crontab, the user needs to set LGSM_SAVE_CRONTAB to true. If set to false, the container will function exactly as it functions now. This variable needs to be documented in the downstream (docker image) repository.