[ENHANCEMENT] The FileSystemBase class#449
Open
NotHyper-474 wants to merge 1 commit into
Open
Conversation
NotHyper-474
force-pushed
the
feat/base-fs-class
branch
from
f7fb14a to
72c6913
Compare
Member
|
This is a great idea. This wasn't done earlier because the previous iteration of FileSystem had no shared functions, but the new one does, so this change is helpful. |
Collaborator
Author
|
I'm keeping this a draft until I figure out why this is breaking mods with the internal code for Funkin'. Oddly, with the public one it works completely fine. Meanwhile, I've been thinking the name |
Contributor
|
How is it breaking Funkin'? |
Collaborator
Author
Mods are recognized by the game, but they aren't being able to add any songs, characters or scripts. |
NotHyper-474
changed the title
BaseFileSystem classFileSystemBase class
NotHyper-474
force-pushed
the
feat/base-fs-class
branch
3 times, most recently
from
be590b8 to
af39bff
Compare
Collaborator
Author
|
Fixed it! It turned out to me a very silly oversight on my part. |
NotHyper-474
force-pushed
the
feat/base-fs-class
branch
from
af39bff to
7472ca9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a base class for file systems to extend, providing shared implementations of methods.
It is an abstract class, meaning it cannot be instantiated directly; therefore, it can only be extended by other classes.
Since most functions have an implementation provided by this class, it makes it easier to make changes to existing FileSystems, reducing the chances of human error or the need to copy-and-paste code.