Default suggestion fade to fastest speed#782
Merged
Merged
Conversation
| static let maximumFadeInDuration: Double = 0.30 | ||
| static let defaultFadeInDuration: Double = 0.10 | ||
| static let defaultFadeInDuration: Double = 0.05 | ||
| static let fadeInDurationStep: Double = 0.05 |
Contributor
There was a problem hiding this comment.
When a user already has cotabbyFadeInDurationSeconds persisted at the old 0.10 value, reset-to-defaults does not remove that key, so load() keeps reading the stale value instead of this new 0.05 default. The visible result is that resetting Appearance settings can leave the fade speed on the old second-fastest tick instead of the new fastest default.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Set the default suggestion fade duration to the fastest Appearance-slider tick (0.05 seconds) so new installs start with the most responsive fade-in behavior.
Validation
swiftlint lint --quiet— exit 0.xcodebuild -project Cotabby.xcodeproj -scheme Cotabby -destination 'platform=macOS' -derivedDataPath build/DerivedData CODE_SIGNING_ALLOWED=NO -jobs 1 build-for-testing— TEST BUILD SUCCEEDED.xcodebuild -project Cotabby.xcodeproj -scheme Cotabby -destination 'platform=macOS' -derivedDataPath build/DerivedData CODE_SIGNING_ALLOWED=NO test-without-building -only-testing:CotabbyTests/SuggestionSettingsStoreTests— TEST EXECUTE SUCCEEDED, 42 tests, 0 failures.Linked issues
None.
Risk / rollout notes
Low risk. This affects only users without a persisted fade-speed preference; saved user settings continue to win. No schema, project, or runtime changes.
Greptile Summary
This PR makes the default suggestion fade-in speed faster.
0.05seconds.Confidence Score: 4/5
The changed default path has one contained reset behavior issue.
Cotabby/Support/SuggestionSettingsStore.swift
Important Files Changed
Reviews (1): Last reviewed commit: "Default suggestion fade to fastest speed" | Re-trigger Greptile