Fix estimated popup vertical alignment#780
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Anchor estimated-geometry suggestion popups to the resolver's text-line box instead of the full input-field chrome. This removes the extra one-row drop in tall single-line controls such as Chrome's omnibox while preserving field-bottom placement for multiline AX fallbacks.
Validation
swiftlint lint --quiet— exit 0.xcodebuild -project Cotabby.xcodeproj -scheme Cotabby -destination 'platform=macOS' -derivedDataPath build/DerivedData CODE_SIGNING_ALLOWED=NO build— BUILD SUCCEEDED.xcodebuild -project Cotabby.xcodeproj -scheme Cotabby -destination 'platform=macOS' -derivedDataPath build/DerivedData CODE_SIGNING_ALLOWED=NO -jobs 1 build-for-testing— TEST BUILD SUCCEEDED.xcodebuild -project Cotabby.xcodeproj -scheme Cotabby -destination 'platform=macOS' -derivedDataPath build/DerivedData CODE_SIGNING_ALLOWED=NO test-without-building -only-testing:CotabbyTests/MirrorOverlayLayoutTests— TEST EXECUTE SUCCEEDED, 20 tests, 0 failures.Linked issues
None.
Risk / rollout notes
Low-risk presentation-only change. Estimated single-line popup cards move upward to the centered caret line; multiline and full-frame fallbacks keep the previous field-bottom anchor. No settings, schema, project, or runtime changes.
Greptile Summary
This PR adjusts estimated mirror popup placement for text fields. The main changes are:
Confidence Score: 5/5
This looks safe to merge.
Important Files Changed
Reviews (1): Last reviewed commit: "Fix estimated popup vertical alignment" | Re-trigger Greptile