Fix default local development signing#779
Merged
Merged
Conversation
| @@ -1943,15 +1943,15 @@ | |||
| LastUpgradeCheck = 2600; | |||
| TargetAttributes = { | |||
| 59F15B162977174E700D0CAA = { | |||
Contributor
There was a problem hiding this comment.
Target Metadata Overrides Signing
When a contributor creates Config/Signing.local.xcconfig with their own team, these automatic-signing target attributes can still make Xcode provision the targets with G946M8K23B. Contributors outside that team can then fail local signed builds even though the documented override resolves DEVELOPMENT_TEAM to their own team.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Default local signing to Cotabby's development team through the shared signing xcconfig, so maintainers can pull
mainand run the dev scheme without Xcode dirtying the generated project. Contributors on other teams retain the one-time, gitignoredSigning.local.xcconfigoverride.Validation
xcodebuild -project Cotabby.xcodeproj -scheme 'Cotabby Dev' -configuration Debug -destination 'platform=macOS' -derivedDataPath build/DerivedData-DefaultTeam build—BUILD SUCCEEDED; resolved teamG946M8K23Band signed with the local Apple Development certificate.xcodebuild ... -showBuildSettings— resolvedDEVELOPMENT_TEAM = G946M8K23BandPRODUCT_BUNDLE_IDENTIFIER = com.jacobfu.tabby.devwithout a local signing file.swiftlint lint --strict --quiet— exit 0.xcodegen generatefollowed bygit diff --check— generated project matchesproject.yml; exit 0.bash -n scripts/dev-setup.sh— exit 0.Linked issues
None.
Risk / rollout notes
The shared team only affects signed local builds. CI and contributor compile checks continue to use
CODE_SIGNING_ALLOWED=NO; contributors who need to run the app with another team can runscripts/dev-setup.shonce, and its gitignored override wins over the shared default.Greptile Summary
This PR changes the default local signing setup for the macOS app.
Confidence Score: 4/5
The local signing override path can still pick the maintainer team in Xcode automatic signing.
Signing.local.xcconfigoverride the shared default.DevelopmentTeam = G946M8K23Bin target attributes.Cotabby.xcodeproj/project.pbxproj
Important Files Changed
Reviews (1): Last reviewed commit: "Fix default local development signing" | Re-trigger Greptile