Replace np.<type alias> with base types#327
Open
zboszor wants to merge 3 commits intoFoundationVision:mainfrom
Open
Replace np.<type alias> with base types#327zboszor wants to merge 3 commits intoFoundationVision:mainfrom
zboszor wants to merge 3 commits intoFoundationVision:mainfrom
Conversation
See https://numpy.org/devdocs/release/1.20.0-notes.html#deprecations Signed-off-by: Zoltán Böszörményi <zboszor@gmail.com>
See https://numpy.org/devdocs/release/1.20.0-notes.html#deprecations Signed-off-by: Zoltán Böszörményi <zboszor@gmail.com>
See https://numpy.org/devdocs/release/1.20.0-notes.html#deprecations Signed-off-by: Zoltán Böszörményi <zboszor@gmail.com>
|
ChatGPT コードレビュー: 分析できませんでした |
|
@ifzhang check this pull request out |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See deprecated type aliases
I chose to use base types instead of using the renamed aliases in order to stay compatible with older numpy and python versions:
np.float -> float
np.int -> int
np.bool -> bool
These numpy types were simply aliases of the base python types.
Explicitly sized types like float32 and float64 were left alone.