fix: add missing signal invocations in Bot.tsx#379
Open
SyncWithRaj wants to merge 2 commits intoFlowiseAI:mainfrom
Open
fix: add missing signal invocations in Bot.tsx#379SyncWithRaj wants to merge 2 commits intoFlowiseAI:mainfrom
SyncWithRaj wants to merge 2 commits intoFlowiseAI:mainfrom
Conversation
There was a problem hiding this comment.
Code Review
This pull request corrects the logic in Bot.tsx by properly invoking isFileUploadAllowed and recordingNotSupported as functions. A review comment identifies a functional issue in the handleDrop handler where an early return prevents e.preventDefault() from executing, which could lead to unintended browser navigation when uploads are disabled.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed logic errors in
Bot.tsxwhere Solid.js signal accessors were being checked as function references instead of being invoked. In Solid.js, signals are functions; referencing them without()evaluates to truthy (the function itself), causing conditional guards to fail.Key Fixes
onRecordingCancelledto correctly invokerecordingNotSupported(). This ensurescancelAudioRecording()is called, preventing the microphone from staying active after a user cancels.handleDropto correctly invokeisFileUploadAllowed(), ensuring that file upload permissions are strictly enforced during drop events.Impact