Skip to content

[6267] Allow users to interact with the Instance drawer/FlowFuse expert in the immersive experience without it overlapping one another#7098

Merged
n-lark merged 15 commits intomainfrom
6267-immersive-expert-ui
Apr 29, 2026
Merged

[6267] Allow users to interact with the Instance drawer/FlowFuse expert in the immersive experience without it overlapping one another#7098
n-lark merged 15 commits intomainfrom
6267-immersive-expert-ui

Conversation

@n-lark
Copy link
Copy Markdown
Contributor

@n-lark n-lark commented Apr 17, 2026

Description

See details & test plan here.

embedded

Related Issue(s)

Resolves #6267

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production
  • Link to Changelog Entry PR, or note why one is not needed.

Labels

  • Includes a DB migration? -> add the area:migration label

@n-lark n-lark self-assigned this Apr 17, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.61%. Comparing base (d53e1dd) to head (7f97053).
⚠️ Report is 16 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7098   +/-   ##
=======================================
  Coverage   76.61%   76.61%           
=======================================
  Files         405      405           
  Lines       20427    20427           
  Branches     4925     4925           
=======================================
  Hits        15650    15650           
  Misses       4777     4777           
Flag Coverage Δ
backend 76.61% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@cstns cstns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome start, and a massive improvement on usability & aesthetics!

I have a couple of things i'd like done slighly differently and a couple of questions as well.

NB. I also found some inconsistencies in guardrails when using the app without a license attached. I don't think they were introduced with the current changes though but i'll create follow ups for them

Comment thread frontend/src/layouts/ImmersiveEditor.vue
Comment thread frontend/src/App.vue
Comment thread frontend/src/composables/DrawerHelper.js
Comment thread frontend/src/pages/device/Editor/index.vue Outdated
Comment thread frontend/src/layouts/ImmersiveEditor.vue Outdated
Comment thread frontend/src/layouts/ImmersiveEditor.vue Outdated
Comment thread frontend/src/layouts/ImmersiveEditor.vue
Comment thread frontend/src/stores/product-expert.js Outdated
Comment thread frontend/src/stores/product-expert.js Outdated
Comment thread frontend/src/stores/ux-drawers.js
…and dialog, move to context store for immersive checks
@cstns cstns self-requested a review April 29, 2026 06:34
Copy link
Copy Markdown
Contributor

@cstns cstns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It has a green light for me in principle. I found a lot of ux niggles that may/may not have been introduced by this change, I'll leave it up to you on what/when to tackle them, for the time being i added them as sub task follow ups to the parent issue.

On a second note, i'm still not 100% happy with the drawer situation but I can live with it. I admit it's more of a personal/ocd note. I'll raise a follow up on that as well at one point

Comment thread frontend/src/mixins/Alerts.js
Comment thread frontend/src/stores/ux-drawers.js Outdated
@cstns cstns self-requested a review April 29, 2026 16:04
@n-lark n-lark merged commit 424fbb5 into main Apr 29, 2026
31 checks passed
@n-lark n-lark deleted the 6267-immersive-expert-ui branch April 29, 2026 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow users to interact with the Instance drawer/FlowFuse expert in the immersive experience without it overlapping one another.

2 participants