Conversation
…awer behavior, update unit tests
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7098 +/- ##
=======================================
Coverage 76.61% 76.61%
=======================================
Files 405 405
Lines 20427 20427
Branches 4925 4925
=======================================
Hits 15650 15650
Misses 4777 4777
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…dialogs, add back in comments
cstns
left a comment
There was a problem hiding this comment.
awesome start, and a massive improvement on usability & aesthetics!
I have a couple of things i'd like done slighly differently and a couple of questions as well.
NB. I also found some inconsistencies in guardrails when using the app without a license attached. I don't think they were introduced with the current changes though but i'll create follow ups for them
…and dialog, move to context store for immersive checks
cstns
left a comment
There was a problem hiding this comment.
It has a green light for me in principle. I found a lot of ux niggles that may/may not have been introduced by this change, I'll leave it up to you on what/when to tackle them, for the time being i added them as sub task follow ups to the parent issue.
On a second note, i'm still not 100% happy with the drawer situation but I can live with it. I admit it's more of a personal/ocd note. I'll raise a follow up on that as well at one point
Description
See details & test plan here.
Related Issue(s)
Resolves #6267
Checklist
flowforge.yml?FlowFuse/helmto update ConfigMap TemplateFlowFuse/CloudProjectto update values for Staging/ProductionLabels
area:migrationlabel