Skip to content

[6943] Pinia Task 14 - account-settings #6979

Merged
n-lark merged 15 commits intomainfrom
6943-pinia-task-14-account-settings
Apr 14, 2026
Merged

[6943] Pinia Task 14 - account-settings #6979
n-lark merged 15 commits intomainfrom
6943-pinia-task-14-account-settings

Conversation

@n-lark
Copy link
Copy Markdown
Contributor

@n-lark n-lark commented Mar 26, 2026

Description

See details here & test plan here.

Related Issue(s)

Resolves #6943

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production
  • Link to Changelog Entry PR, or note why one is not needed.

Labels

  • Includes a DB migration? -> add the area:migration label

@n-lark n-lark self-assigned this Mar 26, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.29%. Comparing base (73b0745) to head (dabab44).
⚠️ Report is 34 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6979   +/-   ##
=======================================
  Coverage   76.29%   76.29%           
=======================================
  Files         405      405           
  Lines       20348    20348           
  Branches     4895     4895           
=======================================
  Hits        15525    15525           
  Misses       4823     4823           
Flag Coverage Δ
backend 76.29% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@n-lark n-lark marked this pull request as ready for review March 27, 2026 18:18
@n-lark n-lark requested a review from cstns March 27, 2026 18:18
Base automatically changed from 6942-pinia-task-13-account-team to main April 7, 2026 09:28
@allthedoll allthedoll added this to the 2.30 milestone Apr 9, 2026
@allthedoll allthedoll moved this to Review in 🛠 Development Apr 9, 2026
Copy link
Copy Markdown
Contributor

@cstns cstns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

massive overhaul, thank you for cleaning house and getting rid of the perimssions mixin!

I had a few concerns but i think I answered my own questions along the way. please don't forget to open an issue for the instance settings security issue you came across and feel free to fix the

pre-empteviley approving because i'm still not clear if you were messing with me on the canCreateTeam method placement so leaving it up to you hehe

@n-lark n-lark merged commit c9047fd into main Apr 14, 2026
30 checks passed
@n-lark n-lark deleted the 6943-pinia-task-14-account-settings branch April 14, 2026 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Review

Development

Successfully merging this pull request may close these issues.

Pinia Task 14 - account-settings

3 participants